Add more tests!

[andrewda]

We can use this issue to divide up some work. I'll add a checklist below with what needs to be done and who it's assigned to. Please comment (or edit yourself in) if you'd like to take on a test!

For newcomers:

1. Choose the component you want to test
2. Comment here which component you'd like to work on
3. We'll update this list with your name

Components

• Badge (@andrewda – test: begin implementing basic component tests #407 )
• Button (@andrewda – test: begin implementing basic component tests #407)
• CodeLine (@andrewda – test: begin implementing basic component tests #407)
• CommentInput (@dyesseyumba - test: add tests for CommentInput #582)
• CommentListItem (@jouderianjr - PR pending)
• DiffBlocks (unclaimed)
• EntityInfo (@andrewda – test: begin implementing basic component tests #407)
• GithubHtmlView (@whitedogg13 - feat: support <details> tag for GithubHtmlView (#528) #819)
• GithubStyle (unclaimed)
• ImageZoom (@jouderianjr - test: Add test to ImageZoom component #548)
• InlineLabel (@jglover - PR pending)
• IssueDescription (@mmendesas - PR pending)
• IssueEventListItem (unclaimed)
• IssueListItem (unclaimed)
• LabelButton (@andrewda – test: begin implementing basic component tests #407)
• LabelListItem (@MarioArnt - test(label-list-item): Add missing tests for LabelListItem component #818)
• MarkdownWebView (unclaimed)
• Members (unclaimed)
• MentionArea (unclaimed)
• NotificationIcon (@ZahraTee - test: add tests for NotificationIcon and RepositorySectionTitle #677)
• NotificationListItem (@alejandronanez - test: add NotificationListItem component tests #589)
• ParallaxScroll (unclaimed)
• RepositoryListItem (unclaimed)
• RepositoryProfile (@alejandronanez - test: Add RepositoryProfile tests #531)
• RepositorySectionTitle (@ZahraTee - test: add tests for NotificationIcon and RepositorySectionTitle #677)
• SearchBar – Android (@dyesseyumba - PR pending)
• SearchBar – iOS (@dyesseyumba - PR pending)
• SectionList (@jamesg1 - PR pending)
• StateBadge (@andrewda – test: begin implementing basic component tests #407)
• ToggleView (@machour – test: begin implementing basic component tests #407)
• UserListItem (unclaimed)
• UserProfile (@alejandronanez - test: add UserProfile unit tests #547)
• ViewContainer (@lucaslago - test(view-component): add tests for view-component #841)

Sections

Actions

• Issue (unclaimed)
• Notifications (unclaimed)
• Organization (unclaimed)
• Repository (unclaimed)
• Search (unclaimed)
• User (unclaimed)

Reducers

• Auth (@jglover - test: Added tests for auth reducer and refactored some other tests #579)
• Issue (@TFarla - Add tests for issue reducer (#518) #830)
• Notifications (@jglover - test: added tests for notifications reducer #567)
• Organization (@TFarla - test: add tests for organization reducer (#518) #831)
• Repository (@TFarla - test(repository.reducer.js): Add tests for repository reducer #832)
• Search (@jglover - test: added search reducer tests #574)
• User (@TFarla - test(user.reducer): Add tests for user reducer #833)

Screens

• Auth (unclaimed)
• Issue (unclaimed)
• Notifications (unclaimed)
• Organization (unclaimed)
• Repository (unclaimed)
• Search (unclaimed)
• User (unclaimed)

Utilities

• Action Helper (@alejandronanez - feat(test): Add test for Action Helpers #555)
• Color Helpers (@ibotdotout - test: Add test for Color Helpers (#518) #565)
• Event Helpers (@andrewda - PR pending)
• Loading Animation (unclaimed)
• Localization Helper (unclaimed)
• Migration Helper (@mbelsky - Add test for Migration Helper (#518) #814)
• Method Helpers (@MarioArnt)
• Text Helper (@ibotdotout - test(text-helper): add test for emojifyText, abbreviateNumber #568)

Miscellaneous

• API (@jjlljj - Test api calls #746)
• Locales – see fix(trans): Make all translations contain same fields #478 (@chinesedfan - test(locales): Add locales test #594)

[jouderianjr]

I'll start slow :) Could you give me ImageZoom and CommentListItem? 💃

[alejandronanez]

I can grab userProfile and RepositoryProfile. Already edited the list!

[machour]

I'd like to implement tests for <GithubHtmlView /> but I'm not sure how to implement them with Enzyme. (I'm fairly new to testing ☺️)

This component does two things:

1. Transform a given HTML to a new HTML with some modifications
2. Hands out this new HTML to <HTMLView />

Should I stick to only testing the first part, or should the output result of be tested too?
What would be the best way to test the HTML transformation (1.) without relying on jest snapshots?

[andrewda]

Yea, I'd stick to the first part (we should really only be testing one component per test, and involving <HTMLView /> in any way gets a little iffy). For testing the transformations, how about adding a couple data files to a __tests__/data/html directory along with their corresponding expected result. Feed the input HTML from the data files into <GithubHtmlView /> and compare the output with the expected output from the result file.

[jglover]

I'll take InlineLabel and perhaps a reducer

[andrewda]

Thank so much @jglover!!

[ibotdotout]

I'll take Color Helpers, Text Helper in Utilities

[serhii-baraniuk]

Oppps. I haven't noticed that @ibotdotout decided to do tests for color helpers :(

[jglover]

Tackled notifications reducer tests, see #567

[dyesseyumba]

I want to take "SearchBar – Android" and "SearchBar – iOS"

[andrewda]

@dyesseyumba <3