Skip to content

fix: Update git2 dependency to include 'ssh' feature - #3009

Merged
extrawurst merged 1 commit into
gitui-org:masterfrom
gcgbarbosa:master
Jul 31, 2026
Merged

fix: Update git2 dependency to include 'ssh' feature#3009
extrawurst merged 1 commit into
gitui-org:masterfrom
gcgbarbosa:master

Conversation

@gcgbarbosa

Copy link
Copy Markdown
Contributor

Added 'ssh' feature to git2 dependency in Cargo.toml

This Pull Request fixes #3008

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Added 'ssh' feature to git2 dependency in Cargo.toml
@extrawurst
extrawurst merged commit d78d264 into gitui-org:master Jul 31, 2026
22 checks passed
@youssefadly237

youssefadly237 commented Aug 1, 2026

Copy link
Copy Markdown

this pr did not commit the Cargo.lock and now it is adding it, it would be confusing if it showed up randomly on the next commit, is it worth a PR?

diff --git a/Cargo.lock b/Cargo.lock
index a699e228..8113e260 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2437,6 +2437,7 @@ checksum = "005d6ae6eac1912906073e069f7db60b1fa98e052a68227824afe3e3a1c59ca2"
 dependencies = [
  "cc",
  "libc",
+ "libssh2-sys",
  "libz-sys",
  "openssl-sys",
  "pkg-config",
@@ -2452,6 +2453,20 @@ dependencies = [
  "libc",
 ]

+[[package]]
+name = "libssh2-sys"
+version = "0.3.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c04141a07bb0c0bc461cb657808764de571702a59bc5c726c400ac9a7625e3ab"
+dependencies = [
+ "cc",
+ "libc",
+ "libz-sys",
+ "openssl-sys",
+ "pkg-config",
+ "vcpkg",
+]
+
 [[package]]
 name = "libz-sys"
 version = "1.1.21"

@gcgbarbosa

Copy link
Copy Markdown
Contributor Author

@youssefadly237 maybe you should write a test to ensure this does not happen again in the future

@youssefadly237

youssefadly237 commented Aug 1, 2026

Copy link
Copy Markdown

A precommit? a CI check? What kind of tests?

@gcgbarbosa

gcgbarbosa commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

I would do a CI because pre-commits can be bypassed.
In this case for example I was in a rush and changed the files on github.com directly.
I knew this was not worth a PR but my gitui workflow was broken and I knew how to fix it. I might as well just save the maintainers a few minutes of debugging.
A pre-commit would not have prevented me from making the mistake.

@youssefadly237

Copy link
Copy Markdown

Hey @extrawurst,

Sorry for pinging, what do think of that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pushing ssh remotes stopped working

3 participants