feat:contrib/model-prism: pluggable LLM backend SPI for ADK Java via ServiceLoader#1199
Open
svetanis wants to merge 1 commit into
Open
feat:contrib/model-prism: pluggable LLM backend SPI for ADK Java via ServiceLoader#1199svetanis wants to merge 1 commit into
ServiceLoader#1199svetanis wants to merge 1 commit into
Conversation
ServiceLoader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
model-prism: pluggable LLM backend SPI for ADK Java viaServiceLoaderPlease ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Related discussion:
2. Description of change:
This is a working prototype demonstrating one way to add pluggable LLM backends to ADK-Java via
ServiceLoader.Problem
Python ADK gets zero-code provider switching for free — dynamic imports and LiteLLM resolve a model string from config at runtime. This PR demonstrates the Java-idiomatic equivalent: a
ServiceLoader-based SPI where a model string in config plus a Maven dependency swap is all it takes.What goes where
Into
google-adk.jar— SPI layer (3 files):ModelProvider— SPI interfaceModelProviderRegistry—ServiceLoaderwiringOpenAiCompatibleLlm— reusable base class for anyPOST /v1/chat/completionsproviderInto
google-adk.jar— HTTP and serialization layer (or replaced by Google's existing implementation):OpenAiHttpClient— HTTP client interface (default impl included; could be backed by ADK's existingChatCompletionsHttpClient)OpenAiMessageSerializer— serializer interface (default impl included; could be replaced byAdkChatSerializerusing ADK 1.1.0 internal DTOs for richer response mapping)Into
RunnerandAdkWebServer.start()(2 lines total):Everything else stays external. Provider JARs (Groq, Ollama, OpenRouter) live outside ADK and self-register via
META-INF/services. No ADK PR is needed to add a new provider — dropping a JAR on the classpath in an ADK application is enough.What's included
model-prism-coreModelProviderSPI +OpenAiCompatibleLlmbase classmodel-prism-groqgroq/.*)model-prism-ollamamodel-prism-openroutermodel-prism-demoTests
13 unit tests, all passing. See PR description for full list.
Manual E2E verified with Groq and Ollama.
Proposed core integration (one line)
Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
The
model-prism-demomodule includes 11 runnable demo classes. To verify end-to-end:For Ollama (no API key required): install Ollama, run
ollama pull llama3, then use model nameollama/llama3.Checklist
Additional context
Modules added under
contrib/model-prism/:model-prism-coreModelProviderSPI,ModelProviderRegistry,OpenAiCompatibleLlmbase classmodel-prism-groqgroq/.*)model-prism-ollamaollama/.*, no API key)model-prism-openrouteropenrouter/.*, free tier available)model-prism-demo