Skip to content

fix: #247 OpenAPIToolSet Parameter required field and description - #256

Merged
Jacksunwei merged 4 commits into
google:mainfrom
sumant-pangotra:#247-OpenAPIToolSet-Considering-Required-parameters
May 2, 2025
Merged

fix: #247 OpenAPIToolSet Parameter required field and description #256
Jacksunwei merged 4 commits into
google:mainfrom
sumant-pangotra:#247-OpenAPIToolSet-Considering-Required-parameters

Conversation

@sumant-pangotra

@sumant-pangotra sumant-pangotra commented Apr 17, 2025

Copy link
Copy Markdown
Contributor
  • If a parameter is set as required : false in OpenAPI spec file . It will not be included in required list generated for function declaration for LLM call
  • If description is not present in parameter schema then use parameter description

fixes #247
#247

@google-cla

google-cla Bot commented Apr 17, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sumant-pangotra sumant-pangotra changed the title Fixed Parameter required field and description OpenAPIToolSet Fixed Parameter required field and description in OpenAPI Spec File Apr 17, 2025
@sumant-pangotra
sumant-pangotra force-pushed the #247-OpenAPIToolSet-Considering-Required-parameters branch from b285861 to e1d467a Compare April 17, 2025 22:14
@sumant-pangotra
sumant-pangotra force-pushed the #247-OpenAPIToolSet-Considering-Required-parameters branch from e1d467a to 27b214d Compare April 17, 2025 22:20
@Jacksunwei Jacksunwei added the ready to pull [Status] This PR is ready to be imported back to Google label May 2, 2025
@Jacksunwei

Copy link
Copy Markdown
Collaborator

@sumant-pangotra could you check the failed conventional commit action and fix it, so that the CL can be generated?

@sumant-pangotra sumant-pangotra changed the title OpenAPIToolSet Fixed Parameter required field and description in OpenAPI Spec File fix: #247 OpenAPIToolSet Parameter required field and description May 2, 2025
@Jacksunwei Jacksunwei added ready to pull [Status] This PR is ready to be imported back to Google and removed ready to pull [Status] This PR is ready to be imported back to Google labels May 2, 2025
copybara-service Bot pushed a commit that referenced this pull request May 2, 2025
--
27b214d by Sumant Pangotra <sumantpangotra@gmail.com>:

Fixed Parameter required field and description

COPYBARA_INTEGRATE_REVIEW=#256 from sumant-pangotra:#247-OpenAPIToolSet-Considering-Required-parameters 42f87a9
PiperOrigin-RevId: 754050217
@Jacksunwei

Copy link
Copy Markdown
Collaborator

Merged in e8fb4ed

@Jacksunwei
Jacksunwei merged commit 3fddac5 into google:main May 2, 2025
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
--
27b214d by Sumant Pangotra <sumantpangotra@gmail.com>:

Fixed Parameter required field and description

COPYBARA_INTEGRATE_REVIEW=google#256 from sumant-pangotra:google#247-OpenAPIToolSet-Considering-Required-parameters 42f87a9
PiperOrigin-RevId: 754050217
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
…ToolSet-Considering-Required-parameters

fix: google#247 OpenAPIToolSet Parameter required field and description 

Merged in google@e8fb4ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be imported back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADK OpenAPIToolSet Not Including Parameter Description And required Field

3 participants