fix: use Optional[list[str]] instead of list[str] | None in cleanup_unused_files to fix schema parsing error - #6536
Open
guptaishaan wants to merge 1 commit into
Open
Conversation
…nused_files to fix schema parsing error The `cleanup_unused_files` tool function used the `X | None` union type syntax (PEP 604) for the `file_patterns` and `exclude_patterns` parameters. The ADK automatic function calling schema generator fails to parse this syntax, causing the error: Signed-off-by: Ishaan <ishaangupta0408@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cleanup_unused_filestool function used theX | Noneunion type syntax (PEP 604) for thefile_patternsandexclude_patternsparameters. The ADK automatic function calling schema generator fails to parse this syntax, causing the error:This error was triggered when opening the agent builder in
adk web, making the assistant chat non-functional. The fix replaceslist[str] | NonewithOptional[list[str]]from thetypingmodule, which the schema generator handles correctly.Fixes #3591.