Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
decide_step_resume treated one answered sibling as coverage for the whole event, so a parallel call that never ran was skipped. Require full id and name coverage (issubset) before continuing. Fixes google#7108 Co-authored-by: Zsanz3 <Zsanz3@users.noreply.github.com>
Name coverage looked only at the last matching response event, so a fully answered parallel pair was treated as incomplete and replayed. Walk every response after the call before testing issubset. Co-authored-by: Zsanz3 <Zsanz3@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-partial-parallel-resume-3209
branch
from
September 15, 2026 22:30
91c561c to
e1a32ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7108
Summary
When one sibling in a parallel tool call was answered,
decide_step_resumetreated the step as fully answered (any-answered), so never-executed parallel calls were not replayed.Changes
issubseton call names/ids (aligned with_pause_left_calls_unanswered)REPLAY_CALLStest_resume_utils.py_replay_function_callsleft as follow-up to keep the diff smallTests