Conversation
…oogle#7142) Apply the same forced-user rule the A2A converter already uses to Runner inbound new_message content: a caller-supplied role must not survive into the provider call, and session-restore must not accept arbitrary authors that bypass fencing.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7142.
The A2A converter already canonicalizes inbound roles to user (the fencing/forced-user family). This applies the same rule at the runner inbound boundary: a caller-chosen Content.role is not preserved into the provider call, closing the unfixed sibling documented in #7142 (including the session-restore author bypass of fencing).
Patch is 5 lines mirroring the converter rule; the applied test flips the splice cells (P1/P2) to held while the restore seam is left open for maintainer design (per the issue).