Issue Listing Private Repositories for User

[untamed-theory]

I am attempting to list all repositories (private and public) for an installed GitHub app using the client.Repositories.List() function.

Problem: It is only returning public repositories. Not private ones, which the app has permission to access.

tr := http.DefaultTransport

//using ghinstallation for auth
itr, err := ghinstallation.NewKeyFromFile(tr, viper.GetInt64("APP_ID"), installationid, viper.GetString("KEY_PATH"))
if err != nil {
	log.Fatal("Error Generating new GitHub key from file: ", err)
}

client := github.NewClient(&http.Client{Transport: itr})

// Make the call to list repositories
opt := &github.RepositoryListOptions{Type: "all"}
orgs, resp, err = newclient.Repositories.List(ctx, p.Org, opt)

I have even tried the following:

• using .WithAuthToken() instead of ghinstallation library
• Using the token to make a raw HTTP call, not using the go-github library.

No matter what, it won't return private repos in the list. Could it be a GitHub API problem? The Installation token that is generated is legitimate, and actually allows me to clone repositories.

Any help would be massively appreciated. I feel like I'm taking crazy pills 😆

[gmlewis]

I couldn't get it to work either. Here was my attempt:

// -*- compile-command: "go run main.go"; -*-

package main

import (
	"context"
	"log"

	dbg "github.com/gmlewis/go-httpdebug/httpdebug"
	"github.com/google/go-github/v56/github"
	"golang.org/x/oauth2"
)

const SECRET = "..."

func main() {
	ts := oauth2.StaticTokenSource(
		&oauth2.Token{AccessToken: SECRET},
	)
	tc := oauth2.NewClient(oauth2.NoContext, ts)
	tp := dbg.New(dbg.WithTransport(tc.Transport))
	client := github.NewClient(tp.Client())
	ctx := context.Background()

	owner := "gmlewis"

	opts := &github.RepositoryListOptions{
		Visibility: "private",
		Type:       "private", // "all", // neither work.
		ListOptions: github.ListOptions{
			PerPage: 1000,
			Page:    1,
		},
	}
	repos, resp, err := client.Repositories.List(ctx, owner, opts)
	if err != nil {
		log.Fatal(err)
	}

	log.Printf("resp.Header: %#v", resp.Header)
	for _, repo := range repos {
		log.Printf("repo: %v", repo.GetFullName())
	}
}

EDIT: I'm pretty confident that this used to work at one point, because it was an old test case of mine.

@untamed-theory - could you please contact GitHub technical support and ask them to take a look at this issue and comment to see if something has changed or if we are doing this wrong?

Thank you!

Please see correct answer below from @WillAbides .

[WillAbides]

The issue here is that client.Repositories.List calls an endpoint that only lists public repos when the user argument is specified. For a github app, you need to use a different endpoint to find repos it has access to. See below.

func listUserReposForApp(ctx context.Context, appID int64, pemPath, user string) ([]*github.Repository, error) {
	pem, err := os.ReadFile(pemPath)
	if err != nil {
		return nil, err
	}
	transport := http.DefaultTransport
	appTransport, err := ghinstallation.NewAppsTransport(transport, appID, pem)
	if err != nil {
		return nil, err
	}
	appClient := github.NewClient(&http.Client{Transport: appTransport})
	inst, _, err := appClient.Apps.FindUserInstallation(ctx, user)
	if err != nil {
		return nil, err
	}
	if inst == nil {
		return nil, fmt.Errorf("no installation found for user %s", user)
	}
	instClient := github.NewClient(
		&http.Client{
			Transport: ghinstallation.NewFromAppsTransport(appTransport, inst.GetID()),
		},
	)
	var userRepos []*github.Repository
	listOpts := &github.ListOptions{PerPage: 3}
	for {
		reposList, resp, err := instClient.Apps.ListRepos(ctx, listOpts)
		if err != nil {
			return nil, err
		}
		userRepos = append(userRepos, reposList.Repositories...)
		if resp.NextPage == 0 {
			break
		}
		listOpts.Page = resp.NextPage
	}
	return userRepos, nil
}

[gmlewis]

Thank you, @WillAbides !
Closing issue as resolved.

[untamed-theory]

Ok. The documentation for client.Repositories.List does claim however that you can specify the condition of private in the listOptions. So either the docs are wrong. I solved this one today by switching to graphql calls 🙃

Thank you both for your insight here @gmlewis and @WillAbides