As described in GitHub's doc, the GitHub App Manifest flow can be executed against a user or an org (https://docs.github.com/en/apps/sharing-github-apps/registering-a-github-app-from-a-manifest#implementing-the-github-app-manifest-flow). Right now, this library only supports on a user, which is far from ideal, because it would mean that a CLI using this library would have a potential critical app be created on an end user GitHub user account. Typically GitHub Apps are for service accounts / privileged access and it does not make sense for an employee, who might leave to hold hostage the app config, potential rotating Private Key and gaining access to org he used to be part of.
Here, instead of https://github.com/settings/apps/new, we should have the option to set an org as the App Owner (i.e. https://github.com/organizations/ORGANIZATION/settings/apps/new)
|
u, err := c.baseURL.Parse("/settings/apps/new") |
As described in GitHub's doc, the GitHub App Manifest flow can be executed against a user or an org (https://docs.github.com/en/apps/sharing-github-apps/registering-a-github-app-from-a-manifest#implementing-the-github-app-manifest-flow). Right now, this library only supports on a user, which is far from ideal, because it would mean that a CLI using this library would have a potential critical app be created on an end user GitHub user account. Typically GitHub Apps are for service accounts / privileged access and it does not make sense for an employee, who might leave to hold hostage the app config, potential rotating Private Key and gaining access to org he used to be part of.
Here, instead of
https://github.com/settings/apps/new, we should have the option to set an org as the App Owner (i.e. https://github.com/organizations/ORGANIZATION/settings/apps/new)go-github/scrape/apps.go
Line 138 in 5f496dd