Skip to content

Fixed headers for EventType & DeliveryID #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sparshev wants to merge 3 commits into from
Closed

Fixed headers for EventType & DeliveryID #3554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8e67de
Fixed headers for EventType & DeliveryID
sparshev Apr 18, 2025
9471298
Fixed test for header
sparshev Apr 18, 2025
48e6ef7
Fixed error message as well
sparshev Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions github/messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ const (
// SHA256SignatureHeader is the GitHub header key used to pass the HMAC-SHA256 hexdigest.
SHA256SignatureHeader = "X-Hub-Signature-256"
// EventTypeHeader is the GitHub header key used to pass the event type.
EventTypeHeader = "X-Github-Event"
EventTypeHeader = "X-GitHub-Event"
// DeliveryIDHeader is the GitHub header key used to pass the unique ID for the webhook event.
DeliveryIDHeader = "X-Github-Delivery"
DeliveryIDHeader = "X-GitHub-Delivery"
)

var (
Expand Down Expand Up @@ -321,7 +321,7 @@ func DeliveryID(r *http.Request) string {
func ParseWebHook(messageType string, payload []byte) (interface{}, error) {
eventType, ok := messageToTypeName[messageType]
if !ok {
return nil, fmt.Errorf("unknown X-Github-Event in message: %v", messageType)
return nil, fmt.Errorf("unknown X-GitHub-Event in message: %v", messageType)
}

event := Event{
Expand Down
2 changes: 1 addition & 1 deletion github/messages_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ func TestDeliveryID(t *testing.T) {
if err != nil {
t.Fatalf("DeliveryID: %v", err)
}
req.Header.Set("X-Github-Delivery", id)
req.Header.Set("X-GitHub-Delivery", id)

got := DeliveryID(req)
if got != id {
Expand Down