Skip to content

chore: Bump golang-ci-lint version to v2.13.1 #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 2 commits into from
Aug 20, 2026
Merged

chore: Bump golang-ci-lint version to v2.13.1 #4463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b03344
chore: Bump golang-ci-lint version to v2.13.1
gmlewis Aug 20, 2026
0199f72
Fix stricter linter errors
gmlewis Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .custom-gcl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: v2.12.2 # this is the version of golangci-lint
version: v2.13.1 # this is the version of golangci-lint
plugins:
- module: "github.com/google/go-github/v90/tools/extraneousnew"
path: ./tools/extraneousnew
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
cache-dependency-path: "**/go.sum"
- uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v9.3.0
with:
version: v2.12.2 # sync with version in .custom-gcl.yml
version: v2.13.1 # sync with version in .custom-gcl.yml
experimental: "automatic-module-directories,no-run-logs-group"

check-openapi:
Expand Down
6 changes: 4 additions & 2 deletions example/newfilewithappauth/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ func main() {
token, _, err := client.Apps.CreateInstallationToken(
context.Background(),
installID,
&github.InstallationTokenOptions{})
&github.InstallationTokenOptions{},
)
if err != nil {
log.Fatalf("failed to create installation token: %v", err)
}
Expand All @@ -76,7 +77,8 @@ func main() {
Content: []byte("foo"),
Message: github.Ptr("sample commit"),
SHA: nil,
})
},
)
if err != nil {
log.Fatalf("failed to create new file: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1577,7 +1577,7 @@ func (r *ErrorResponse) Is(target error) bool {
return false
}
if r.Block.CreatedAt != nil && v.Block.CreatedAt != nil {
if *(r.Block.CreatedAt) != *(v.Block.CreatedAt) {
if *r.Block.CreatedAt != *v.Block.CreatedAt {
return false
}
}
Expand Down
18 changes: 9 additions & 9 deletions github/projects_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ func TestProjectsService_ListOrganizationProjectFields(t *testing.T) {
return resp, err
})
ctxBypass := context.WithValue(ctx, BypassRateLimitCheck, true)
if _, _, err = client.Projects.ListOrganizationProjectFields(ctxBypass, "o", 1, &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{Before: ("b"), After: ("a")}}); err != nil {
if _, _, err = client.Projects.ListOrganizationProjectFields(ctxBypass, "o", 1, &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{Before: "b", After: "a"}}); err != nil {
t.Fatalf("unexpected error when both before/after set: %v", err)
}
}
Expand Down Expand Up @@ -274,7 +274,7 @@ func TestProjectsService_ListUserProjectFields(t *testing.T) {
]`)
})

opts := &ListProjectsOptions{Query: ("text"), ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: ("2"), Before: ("1")}}
opts := &ListProjectsOptions{Query: "text", ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: "2", Before: "1"}}
ctx := t.Context()
fields, _, err := client.Projects.ListUserProjectFields(ctx, "u", 1, opts)
if err != nil {
Expand All @@ -300,7 +300,7 @@ func TestProjectsService_ListUserProjectFields(t *testing.T) {
return resp, err
})
ctxBypass := context.WithValue(ctx, BypassRateLimitCheck, true)
if _, _, err = client.Projects.ListUserProjectFields(ctxBypass, "u", 1, &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{Before: ("b"), After: ("a")}}); err != nil {
if _, _, err = client.Projects.ListUserProjectFields(ctxBypass, "u", 1, &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{Before: "b", After: "a"}}); err != nil {
t.Fatalf("unexpected error when both before/after set: %v", err)
}
}
Expand Down Expand Up @@ -418,7 +418,7 @@ func TestProjectsService_ListUserProjects_pagination(t *testing.T) {
t.Fatalf("expected resp.After=ucursor2 got %q", resp.After)
}

opts := &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: (resp.After)}}
opts := &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: resp.After}}
second, resp2, err := client.Projects.ListUserProjects(ctx, "u", opts)
if err != nil {
t.Fatalf("second page error: %v", err)
Expand Down Expand Up @@ -491,7 +491,7 @@ func TestProjectsService_ListOrganizationProjectFields_pagination(t *testing.T)
t.Fatalf("expected resp.After=cursor2 got %q", resp.After)
}

opts := &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: (resp.After)}}
opts := &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: resp.After}}
second, resp2, err := client.Projects.ListOrganizationProjectFields(ctx, "o", 1, opts)
if err != nil {
t.Fatalf("second page error: %v", err)
Expand Down Expand Up @@ -537,7 +537,7 @@ func TestProjectsService_ListOrganizationProjects_pagination(t *testing.T) {
t.Fatalf("expected resp.After=ocursor2 got %q", resp.After)
}

opts := &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: (resp.After)}}
opts := &ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: resp.After}}
second, resp2, err := client.Projects.ListOrganizationProjects(ctx, "o", opts)
if err != nil {
t.Fatalf("second page error: %v", err)
Expand Down Expand Up @@ -565,7 +565,7 @@ func TestProjectsService_ListOrganizationProjectItems(t *testing.T) {
fmt.Fprint(w, `[{"id":17,"node_id":"PVTI_node"}]`)
})

opts := &ListProjectItemsOptions{ListProjectsOptions: ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: ("2"), Before: ("1"), PerPage: (50)}, Query: ("status:open")}, Fields: []int64{10, 11}}
opts := &ListProjectItemsOptions{ListProjectsOptions: ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{After: "2", Before: "1", PerPage: 50}, Query: "status:open"}, Fields: []int64{10, 11}}
ctx := t.Context()
items, _, err := client.Projects.ListOrganizationProjectItems(ctx, "o", 1, opts)
if err != nil {
Expand All @@ -590,7 +590,7 @@ func TestProjectsService_ListOrganizationProjectItems(t *testing.T) {
})

ctxBypass := context.WithValue(ctx, BypassRateLimitCheck, true)
if _, _, err = client.Projects.ListOrganizationProjectItems(ctxBypass, "o", 1, &ListProjectItemsOptions{ListProjectsOptions: ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{Before: ("b"), After: ("a")}}}); err != nil {
if _, _, err = client.Projects.ListOrganizationProjectItems(ctxBypass, "o", 1, &ListProjectItemsOptions{ListProjectsOptions: ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{Before: "b", After: "a"}}}); err != nil {
t.Fatalf("unexpected error when both before/after set: %v", err)
}
}
Expand Down Expand Up @@ -827,7 +827,7 @@ func TestProjectsService_ListUserProjectItems(t *testing.T) {
fmt.Fprint(w, `[{"id":7,"node_id":"PVTI_user"}]`)
})
ctx := t.Context()
items, _, err := client.Projects.ListUserProjectItems(ctx, "u", 2, &ListProjectItemsOptions{ListProjectsOptions: ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{PerPage: (20)}, Query: ("type:issue")}})
items, _, err := client.Projects.ListUserProjectItems(ctx, "u", 2, &ListProjectItemsOptions{ListProjectsOptions: ListProjectsOptions{ListProjectsPaginationOptions: ListProjectsPaginationOptions{PerPage: 20}, Query: "type:issue"}})
if err != nil {
t.Fatalf("ListUserProjectItems error: %v", err)
}
Expand Down
15 changes: 10 additions & 5 deletions tools/metadata/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ func TestUpdateOpenAPI(t *testing.T) {
URL: "https://docs.github.com/rest/reference/a",
},
},
})),
}),
),
},
"ghec/ghec.json": openapi3.T{
Paths: openapi3.NewPaths(
Expand All @@ -88,7 +89,8 @@ func TestUpdateOpenAPI(t *testing.T) {
URL: "https://docs.github.com/rest/reference/a",
},
},
})),
}),
),
},
"ghes-3.9/ghes-3.9.json": openapi3.T{
Paths: openapi3.NewPaths(
Expand All @@ -98,7 +100,8 @@ func TestUpdateOpenAPI(t *testing.T) {
URL: "https://docs.github.com/rest/reference/a",
},
},
})),
}),
),
},
"ghes-3.10/ghes-3.10.json": openapi3.T{
Paths: openapi3.NewPaths(
Expand All @@ -108,7 +111,8 @@ func TestUpdateOpenAPI(t *testing.T) {
URL: "https://docs.github.com/rest/reference/a",
},
},
})),
}),
),
},
"ghes-2.22/ghes-2.22.json": openapi3.T{
Paths: openapi3.NewPaths(
Expand All @@ -118,7 +122,8 @@ func TestUpdateOpenAPI(t *testing.T) {
URL: "https://docs.github.com/rest/reference/a",
},
},
})),
}),
),
},
})

Expand Down
Loading