refactor!: Pass org invitation requests by value - #4551
Open
jvm986 wants to merge 2 commits into
Open
Conversation
Rename CreateOrgInvitationOptions to CreateOrgInvitationRequest and pass it by value to OrganizationsService.CreateOrgInvitation. Update tests, generated accessors, and lint exceptions. Refs google#3644
jvm986
marked this pull request as ready for review
September 14, 2026 05:36
gmlewis
added
NeedsReview
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4551 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 197 197
Lines 18252 18252
=======================================
Hits 17991 17991
Misses 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Sep 14, 2026
| - CommitsSearchResult.Commits | ||
| - CommitsSearchResult.Total | ||
| - CreateOrgInvitationOptions.TeamID # TODO: TeamIDs | ||
| - CreateOrgInvitationRequest.TeamID # TODO: TeamIDs |
Contributor
There was a problem hiding this comment.
Can we also fix this, since we're already making a breaking API change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
OrganizationsService.CreateOrgInvitationnow takesCreateOrgInvitationRequest(by value).Rename
CreateOrgInvitationOptionstoCreateOrgInvitationRequestand pass it by value toOrganizationsService.CreateOrgInvitation.Refs #3644
cc @JamBalaya56562 @ManavSharma142 @stevehipwell