Skip to content

fix: Re-add ldapdb for ghes team creation - #4553

Merged
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:fix-team-create-ghes-ldapdn
Sep 14, 2026
Merged

fix: Re-add ldapdb for ghes team creation#4553
gmlewis merged 1 commit into
google:masterfrom
stevehipwell:fix-team-create-ghes-ldapdn

Conversation

@stevehipwell

Copy link
Copy Markdown
Contributor

This PR re-adds the LDAPDN field to the CreateTeamRequest struct for usage by gitHub Enterprise Server. This Field was incorrectly removed in #4446.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (440bc88) to head (b838c57).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4553   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         197      197           
  Lines       18252    18252           
=======================================
  Hits        17991    17991           
  Misses        261      261           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stevehipwell!
LGTM.
Merging.

@gmlewis
gmlewis merged commit d689e27 into google:master Sep 14, 2026
15 checks passed
@stevehipwell
stevehipwell deleted the fix-team-create-ghes-ldapdn branch September 14, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants