Skip to content

Fix issue 1428, Eclipse plugin commonmark dependency - #1455

Open
mihnita wants to merge 1 commit into
google:masterfrom
mihnita:mihai_fix_commonmark
Open

mihnita wants to merge 1 commit into
google:masterfrom
mihnita:mihai_fix_commonmark

Conversation

@mihnita

@mihnita mihnita commented Sep 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@mihnita
mihnita force-pushed the mihai_fix_commonmark branch from f0e16f5 to 88a92d9 Compare September 14, 2026 08:24
@mihnita

mihnita commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Tested with the latest Eclipse (2026-09).

The current PR uses the org.commonmark included with Eclipse, and uses dependency-resolution/extraRequirements to tell the user that the org.commonmark plugin is required.
This seems cleaner, and we behave more like a standard Eclipse plugin.

The drawback is that we depend on the org.commonmark included with Eclipse,
whatever that is (0.30.0 for Eclipse 2026-09, 0.24.0 for Eclipse 2025-06, etc)

The alternative is to pack in the plugin the exact org.commonmark version we
tested the formatter with.
We would need the shaded jar for that, google-java-format-{version}-all-deps.jar.
Or "shade" the org.commonmark in the plugin itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant