Skip to content

client: add withDefaultParams method#76

Merged
rakyll merged 5 commits into
googleapis:masterfrom
proppy:defaultparam
Aug 13, 2013
Merged

client: add withDefaultParams method#76
rakyll merged 5 commits into
googleapis:masterfrom
proppy:defaultparam

Conversation

@proppy

@proppy proppy commented Aug 10, 2013

Copy link
Copy Markdown
Contributor

Usage:

client.plus.withDefaultParams({a: 1, b: 'foo'}).method({a: 2});

Create a new request with the following params:

{a: 2, b: 'foo'}

@rakyll

rakyll commented Aug 10, 2013

Copy link
Copy Markdown
Contributor

Some merge conflicts are there, otherwise LGTM.

@proppy

proppy commented Aug 13, 2013

Copy link
Copy Markdown
Contributor Author

PTAL

Comment thread lib/client.js Outdated

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@proppy

proppy commented Aug 13, 2013

Copy link
Copy Markdown
Contributor Author

PTAL

@rakyll

rakyll commented Aug 13, 2013

Copy link
Copy Markdown
Contributor

Merging, thanks. I will add a comment extend is not deep extend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants