refactor: use version functions from common - #4065
Merged
coryan merged 2 commits intoMay 8, 2020
Merged
Conversation
For new libraries (where we have no backward compatibility constraints) we use the `google::cloud::version*()` functions (via using declarations). I think having these functions in the right namespace is useful, but if somebody feels strongly we can just remove them altogether.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #4065 +/- ##
==========================================
- Coverage 93.60% 93.56% -0.04%
==========================================
Files 836 832 -4
Lines 64803 64787 -16
==========================================
- Hits 60658 60618 -40
- Misses 4145 4169 +24
Continue to review full report at Codecov.
|
coryan
marked this pull request as ready for review
May 8, 2020 19:55
devjgm
approved these changes
May 8, 2020
devjgm
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For new libraries (where we have no backward compatibility constraints)
we use the
google::cloud::version*()functions (via usingdeclarations). I think having these functions in the right namespace is
useful, but if somebody feels strongly we can just remove them
altogether.
This fixes #3712
This change is