Skip to content

use new googleapis javadoc page - #2862

Merged
pongad merged 1 commit into
googleapis:masterfrom
pongad:doc-link
Feb 7, 2018
Merged

use new googleapis javadoc page#2862
pongad merged 1 commit into
googleapis:masterfrom
pongad:doc-link

Conversation

@pongad

@pongad pongad commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2018

@garrettjonesgoogle garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad
pongad merged commit 1f2f3b6 into googleapis:master Feb 7, 2018
@pongad
pongad deleted the doc-link branch February 7, 2018 00:29
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
* chore(main): release 3.11.4-SNAPSHOT

* chore: generate libraries at Fri Feb 14 15:41:17 UTC 2025

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
suztomo pushed a commit that referenced this pull request Mar 9, 2026
* deps: update actions/checkout action to v4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
* fix: cast for Proto type

* fix: add null check

* feat(spanner): add ENUM compatibility with getLongArray

* feat: fix argument

* feat: fix bug
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
The new protocol changes the paradigm of bigtable service from an RPC server where each operation is independent to more of a file like model where a table is opened and allows many read & write operations. This will have a significant impact on lowering latencies. All of the changes are internal to the client and the existing public surface remains the same. By default the new protocol is disabled and will be slowly enabled in the future using the client config api.

Notable changes:
- When the new protocol is enabled, the BigtableClientFactory doesnt share the underlying ChannelPool. The new ChannelPool is tracks the connected server, so sharing a channel between multiple resource is no longer possible. 
- The new protocol does not support custom TransportProviders, setting one will force a fallback to the classic protocol
- Retries have been revamped: 
   - the client now tracks how far an rpc went which allows the client to retry non-idempotent rpcs safely
   - attempt timeouts are no longer relevant, they have been replaced with heartbeats
   - Mutations that are not idempotent (have serverside timestamps or counters) are now correctly identified and will be retried if they left the client
- The new transport supports the ambient grpc Context and will consistently respect the ambient deadlines and cancellation
- Customers can opt out of the slow rollout by setting the env var `CBT_DISABLE_SESSIONS=true`
igorbernstein2 added a commit that referenced this pull request Jul 1, 2026
…ion_load is 0 (#13629)

## Summary

- `ClientConfigurationManager.normalizeConfig()` overlays the sys-prop
override into the builder, then guards a "clear session_configuration
when disabled" branch on `session_load`. The guard was reading `cfg`
(the original server response), not the merged builder, so any client
that supplied a nonzero `session_load` via the
`bigtable.internal.client-config-override` sys-prop still had its entire
`session_configuration` wiped whenever the server returned
`session_load=0`.
- In practice: such clients ran with no sessions pre-started,
`DynamicPicker` logged `LOADBALANCINGSTRATEGY_NOT_SET`, and every RPC
fell through to the old stack — silently invalidating any local session
validation using the override.
- Fix: read `session_load` from the merged builder so the override is
respected. Bug has been present since the initial commit of the session
protocol stack (#2862).

## Test plan

- [x] New regression test
`ClientConfigurationManagerTest#testDisabledSessionsOverriddenBySysProp`
— server returns `session_load=0` + sys-prop override sets
`session_load=0.75`; asserts the effective config keeps the override's
`session_load` and the default `SessionPoolConfiguration`, and that
`areSessionsRequired()` is true. Verified the test fails on the unfixed
code (`expected 0.75 but was 0.0`) and passes with the fix.
- [x] Full `ClientConfigurationManagerTest` suite passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants