Skip to content

Fix projectName parsing in GapicSpannerRpc #6746

Merged
skuruppu merged 3 commits into
masterfrom
mb.fix_instance_names
Nov 15, 2019
Merged

Fix projectName parsing in GapicSpannerRpc #6746
skuruppu merged 3 commits into
masterfrom
mb.fix_instance_names

Conversation

@mbril

@mbril mbril commented Nov 12, 2019

Copy link
Copy Markdown

To accept project names that contain special characters.

Like projects within an organization.

…at contain special charecters

Like projects within an organizations.
@mbril mbril requested review from olavloite and skuruppu November 12, 2019 20:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2019

@skuruppu skuruppu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can also fix the code format issue, that'd be great.

@codecov

codecov Bot commented Nov 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6746 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6746      +/-   ##
============================================
- Coverage     46.37%   46.37%   -0.01%     
- Complexity    28024    28028       +4     
============================================
  Files          2614     2615       +1     
  Lines        288317   288309       -8     
  Branches      33810    33809       -1     
============================================
- Hits         133715   133710       -5     
+ Misses       144336   144334       -2     
+ Partials      10266    10265       -1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/bigquery/Routine.java 79.24% <0%> (-3.11%) 11% <0%> (ø)
.../google/cloud/spanner/jdbc/CredentialsService.java 90.47% <0%> (-0.64%) 8% <0%> (-3%)
...rc/main/java/com/google/cloud/storage/Storage.java 79.39% <0%> (ø) 0% <0%> (ø) ⬇️
...google/cloud/logging/logback/MDCEventEnhancer.java 83.33% <0%> (ø) 4% <0%> (?)
...in/java/com/google/cloud/bigquery/RoutineInfo.java 67.47% <0%> (+0.52%) 21% <0%> (+1%) ⬆️
.../google/cloud/logging/logback/LoggingAppender.java 68.5% <0%> (+4.72%) 30% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5f924...c069771. Read the comment docs.

@mbril mbril requested a review from skuruppu November 14, 2019 07:05
…ogle/cloud/spanner/spi/v1/GapicSpannerRpc.java

Co-Authored-By: skuruppu <skuruppu@google.com>
@skuruppu skuruppu merged commit 2f3d78f into master Nov 15, 2019
@skuruppu skuruppu deleted the mb.fix_instance_names branch November 15, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants