Add integration test and example jar.#714
Merged
jean-philippe-martin merged 1 commit intoMar 25, 2016
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration tests exercise the actual GCS and make sure we can read and write. They use environment variables so we should be able to set them up for Travis.
This also includes an example that illustrates how we can add a jar to an existing project to give it the ability to read/write GCS files.
This example relies on making a "fat" jar. We have multiple options there:
pro: you can still add GCS support via recompiling code and adding gcloud-nio as a maven dependency
con: adding GCS support without recompiling is now super-annoying because you need to add a ton of jars. This greatly diminishes NIO's magic.
pro: you can run it with a simple command line, and adding the nio jar gets you GCS support. No change to the other jars, the ones you're likely to actually use.
con: this isn't representative of adding GCS support to legacy binaries, because they won't link those dependencies already.
pro: by adding this jar to the classpath you can super-easily add GCS support to legacy code. You can still also use a maven dependency if you prefer.
con: if you're trying to add GCS NIO to something that already has some gcloud support, you get redundant jars (unless use the maven deps).