Skip to content

chore: update .nycrc, Contributing.md, and .gitignore across packages - #9144

Draft
bshaffer wants to merge 2 commits into
pnpmfrom
pnpm-config-updates
Draft

chore: update .nycrc, Contributing.md, and .gitignore across packages#9144
bshaffer wants to merge 2 commits into
pnpmfrom
pnpm-config-updates

Conversation

@bshaffer

Copy link
Copy Markdown
Contributor

Separated from #8973 to keep the core PNPM migration PR focused.

This PR applies the changes across subpackages for:

  • .nycrc configuration updates
  • CONTRIBUTING.md instructions (updating npm -> pnpm)
  • .gitignore cleanups across packages

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates package management and scripts from npm to pnpm across multiple packages, updating CONTRIBUTING.md files, removing package-lock.json and yarn.lock from .gitignore files, and simplifying coverage reporters in .nycrc files. Feedback highlights that some instances of npm run samples-test were missed in the CONTRIBUTING.md updates, and warns against manually editing auto-generated baseline and test-fixture files instead of updating the upstream generator templates.


# Run unit tests.
npm test
pnpm run test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In this file (and many other CONTRIBUTING.md files across the repository), the command npm run samples-test on line 61 was missed during the migration from npm to pnpm. Please update it to pnpm run samples-test for consistency.

1. Install dependencies:

npm install
pnpm install

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It appears that CONTRIBUTING.md (and potentially .gitignore files) in the baseline and test-fixture directories are being manually updated here. According to the repository rules, manual edits to auto-generated files or baseline files should be avoided as they will be overwritten during the next regeneration. Please ensure that the upstream generator templates (or the source files used by the generator) are updated instead, and then regenerate these baseline/test-fixture files.

References
  1. Do not manually edit auto-generated files to fix typos or make other changes, as these edits will be overwritten during the next regeneration. Instead, apply the fixes upstream in the generator or templates.

@bshaffer
bshaffer force-pushed the pnpm-config-updates branch from afc9e58 to 5b45a3c Compare August 14, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant