fix(sqlalchemy-spanner): fix get_multi_indexes crash on SEARCH indexes#17907
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Spanner dialect to exclude SEARCH indexes from the results of get_multi_indexes and improves robustness when handling null or missing column orderings. It also adds unit tests to verify these changes. The reviewer suggested a cleaner approach for handling columns without explicit sorting by omitting them from the column_sorting dictionary entirely instead of mapping them to None, which aligns better with SQLAlchemy standards. Corresponding updates to the unit tests were also recommended.
sakthivelmanii
force-pushed
the
fix-spanner-reflection-search-index
branch
2 times, most recently
from
July 27, 2026 13:56
afe57b1 to
7b0f4c0
Compare
sakthivelmanii
force-pushed
the
fix-spanner-reflection-search-index
branch
from
July 27, 2026 13:58
7b0f4c0 to
cfc408f
Compare
sakthivelmanii
enabled auto-merge (squash)
July 27, 2026 14:08
olavloite
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕