chore: add property frequencyPenalty in type defintions#394
Merged
Conversation
product-auto-label
Bot
added
the
api: aiplatform
qiaodev
added
the
kokoro:force-run
qiaodev
changed the title
yoshi-kokoro
removed
the
kokoro:force-run
qiaodev
approved these changes
Aug 21, 2024
yyyu-google
reviewed
Aug 21, 2024
yyyu-google
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
qiaodev
changed the title
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all, was working with gemini-flash-1.5 and noticed that frequencyPenalty was not documented in typescript. Taken from these docs: https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/inference
I validated that it gets parsed into
formulateRequestin generative_models.js when callinggenerateContent.One item I was not sure about was how much input validate we want to add?
I see we are validating
topKinvalidateGenerationConfigbut that is the only thing, all other properties are missing and will error out on the API side.Let me know if you want me to add checks there or change anything else. I have signed the Contributor License Agreement
Thank you!