This repository was archived by the owner on Mar 2, 2026. It is now read-only.
fix: type hinting in collection.py - #688
Merged
Merged
Conversation
Mostly adding `| None` on all fields that may have `None` as a default value.
Mariatta
suggested changes
Feb 14, 2023
Mariatta
left a comment
Contributor
There was a problem hiding this comment.
The | syntax is only available in Python 3.10+. Since we still support Python 3.7+, then this should be using Union instead of |.
e.g
from typing import Union
...
document_id: Union[str, None]
Use Union to be compatible with 3.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly adding
| Noneon all fields that may haveNoneas a default value.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #687 🦕