This repository was archived by the owner on May 6, 2026. It is now read-only.
fix: Drop Python 2 support - #826
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: datastore
parthea
reviewed
Nov 15, 2022
parthea
left a comment
parthea
left a comment
Contributor
There was a problem hiding this comment.
Added minor observations
Cloud NDB is one of the final Cloud Client libraries to support Python 2 and retaining support for it will prevent us from updating to the newest version of the underlying Datastore libraries. Not considering this a breaking change because pip will respect python_requires in setup.py and not install a version that doesn't support it anymore.
parthea
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
parthea
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud NDB is one of the final Cloud Client libraries to support Python 2 and retaining support for it will prevent us from updating to the newest version of the underlying Datastore libraries.
Not considering this a breaking change because pip will respect python_requires in setup.py and not install a version that doesn't support it anymore.
BEGIN_COMMIT_OVERRIDE
fix: Drop Python 2 support
Release-As: 1.12.0
END_COMMIT_OVERRIDE