Skip to content

chore(tombstone-library): fix version.rb require and files path in gemspec template - #454

Merged
torreypayne merged 1 commit into
mainfrom
fix/tombstone-gemspec-version-path
Aug 12, 2026
Merged

chore(tombstone-library): fix version.rb require and files path in gemspec template#454
torreypayne merged 1 commit into
mainfrom
fix/tombstone-gemspec-version-path

Conversation

@torreypayne

@torreypayne torreypayne commented Aug 11, 2026

Copy link
Copy Markdown
Member

Fixes the path to version.rb in gemspec-template.erb when tombstoning a gem.

Technical Context

In toys/tombstone-library/.toys.rb, generate_files writes the tombstone version constant to:

mkdir_p "lib/#{namespace_dir}"
generate_one "lib/#{namespace_dir}/version.rb", "version-template.erb"

However, gemspec-template.erb previously omitted the lib/ directory prefix:

  • require File.expand_path("<%= namespace_dir %>/version", __dir__) -> require File.expand_path("lib/<%= namespace_dir %>/version", __dir__)
  • gem.files = [..., "<%= namespace_dir %>/version.rb"] -> gem.files = [..., "lib/<%= namespace_dir %>/version.rb"]

Failure Modes Resolved

  1. Gemspec Loading / Build Failures: Any evaluation of the generated gemspec (via rake build, bundle install, or Gem::Specification.load) previously attempted to require <gem_root>/<namespace>/version.rb, raising LoadError: cannot load such file.
  2. Missing Version File in Package: Because gem.files did not reference lib/<namespace_dir>/version.rb, gem build failed to include version.rb in the packaged .gem archive.

Repro & Verification

# 1. Create dummy multi-namespace skeleton
mkdir -p my-sample-gem/lib/my/sample/gem
touch my-sample-gem/{README.md,LICENSE.md,.yardopts}
cat << 'EOF' > my-sample-gem/lib/my/sample/gem/version.rb
module My; module Sample; module Gem; VERSION = "1.0.0"; end; end; end
EOF

# 2. Testing unpatched template (fails with LoadError):
# require File.expand_path("my/sample/gem/version", __dir__)
ruby -e "Gem::Specification.load('my-sample-gem/my-sample-gem.gemspec')"
# => LoadError: cannot load such file -- .../my-sample-gem/my/sample/gem/version

# 3. Testing patched template (passes & builds package cleanly):
# require File.expand_path("lib/my/sample/gem/version", __dir__)
ruby -e "spec = Gem::Specification.load('my-sample-gem/my-sample-gem.gemspec'); puts spec.name + ' ' + spec.version.to_s"
# => my-sample-gem 1.0.0

@torreypayne
torreypayne requested a review from a team as a code owner August 11, 2026 22:50
@torreypayne
torreypayne marked this pull request as draft August 11, 2026 23:26
@aandreassa

Copy link
Copy Markdown
Contributor

You can also merge this as chore since we are not publishing anything! (it is not an actual gem)

@aandreassa aandreassa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@torreypayne torreypayne changed the title fix(tombstone-library): fix version.rb require and files path in gemspec template chore(tombstone-library): fix version.rb require and files path in gemspec template Aug 12, 2026
@torreypayne
torreypayne force-pushed the fix/tombstone-gemspec-version-path branch from 41bd572 to 5de6471 Compare August 12, 2026 22:03
@torreypayne
torreypayne marked this pull request as ready for review August 12, 2026 22:03
@torreypayne
torreypayne merged commit 68f947a into main Aug 12, 2026
17 checks passed
@torreypayne
torreypayne deleted the fix/tombstone-gemspec-version-path branch August 12, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants