chore(tombstone-library): preserve version.rb untouched when tombstoning - #456
Closed
torreypayne wants to merge 1 commit into
Closed
chore(tombstone-library): preserve version.rb untouched when tombstoning#456torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
…ping for release-please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
toys/tombstone-libraryto leave the existinglib/**/version.rbfile completely untouched when tombstoning a library, rather than modifying or regenerating it from a template.Details
In monorepos managed by Release Please (e.g.
google-cloud-ruby),release-pleaseis responsible for bumpingversion.rband generating changelogs upon merging a breaking change (feat!:).Previously,
toys tombstone-librarydeleted all files and generated a newversion.rbfromversion-template.erb.This change:
delete_filesto preserve the existinglib/#{namespace_dir}/version.rbfile as-is without touching it.version-template.erband the generation step forversion.rb.gem_versionarguments.This ensures zero unnecessary diffs to
version.rbduring tombstoning, allowing Release Please to manage the SemVer major bump upon merge.