chore(tombstone-library): remove all versioning logic and preserve existing version.rb - #457
Merged
Merged
Conversation
torreypayne
force-pushed
the
chore/tombstone-remove-versioning
branch
from
August 12, 2026 22:22
ce947ea to
a401bd7
Compare
torreypayne
force-pushed
the
chore/tombstone-remove-versioning
branch
from
August 12, 2026 22:25
a401bd7 to
f2dd97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all versioning arguments, helpers, and template generation from
toys/tombstone-library, leaving the existinglib/**/version.rbfile completely untouched when tombstoning a library.Changes
optional_arg :gem_versionfrom tool flags.ensure_gem_versionandversion_linesmethods.toys/tombstone-library/.data/version-template.erb.delete_filesto preserve the existinglib/#{namespace_dir}/version.rbfile without modifying or regenerating it.version.rbgeneration step fromgenerate_files.Rationale
In monorepos managed by Release Please (such as
google-cloud-ruby),release-pleaseis solely responsible for bumpingversion.rband generating changelogs upon merging a breaking change (feat!:). Removing versioning logic from the generator prevents unnecessary version churn and diffs.