fix(audits): avoid false positives in 9ABE - #148
Merged
enisdenjo merged 3 commits intoJun 23, 2025
Conversation
enisdenjo
approved these changes
Jun 23, 2025
5 tasks
theguild-bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
# [1.23.0](v1.22.4...v1.23.0) (2026-08-07) ### Bug Fixes * add support for GraphQL v17 ([#156](#156)) ([ae03a11](ae03a11)), closes [#155](#155) * **audits:** avoid false positives in 9ABE ([#148](#148)) ([5587c03](5587c03)) * **audits:** inconsistency between D6D5 and 6A70 ([#147](#147)) ([eac6dc8](eac6dc8)) * **audits:** incorrect status code range ([#145](#145)) ([08b4ed2](08b4ed2)) ### Features * **audit:** graphql-response+json parsing failure handling ([#149](#149)) ([81e6a07](81e6a07))
Collaborator
|
🎉 This PR is included in version 1.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit function of 9ABE sets no
content-typeto trigger a 4xx status code.However, it also sets no request body, which can also trigger a 4xx status code as per A5BF.
This can lead to false positives for this audit check if a server only responds with 4xx because of the missing request body, but not because of the missing
content-typeheader.This PR updates 9ABE to include a valid request body to ensure the 4xx status is triggered based on the missing
content-typeheader. Additionally, I updated 9ABE from MAY to SHOULD to match the relevant part of the spec.