Replaced select.select() with select.epoll() in SocketcanBus#2056
Open
bhicks-stackav wants to merge 2 commits into
Open
Replaced select.select() with select.epoll() in SocketcanBus#2056bhicks-stackav wants to merge 2 commits into
bhicks-stackav wants to merge 2 commits into
Conversation
Collaborator
|
Your solution is better than #2057, if you can make the tests pass i will merge this one. |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
@zariiii9003 sorry about that. I believe I've addressed the issue. Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
select.select()withselect.epoll()inSocketcanBusto avoid aValueErrorbeing raised when a high number of files (>1024) are openRelated Issues / Pull Requests
SocketcanBusdoes not support socket file descriptors over 1023 #2053Type of Change
Checklist
tox).Additional Notes