fix(player): add onRuntimeReady to test callbacks mock#1537
Closed
vanceingalls wants to merge 1 commit into
Closed
fix(player): add onRuntimeReady to test callbacks mock#1537vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
MessageHandlerCallbacks requires onRuntimeReady (runtime-message-handler.ts:29) but the test mock omitted it — TS2741 broke the CI Typecheck job for every open PR. Add the missing vi.fn(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Superseded — the onRuntimeReady mock fix already landed on main (v0.6.110). This branch duplicated it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageHandlerCallbacksrequiresonRuntimeReady(runtime-message-handler.ts:29) but the test mock inruntime-message-handler.test.tsomitted it. This TS2741 error broke the CITypecheckjob onmain— and therefore on every open PR (e.g. #1533). One-line fix: add the missingvi.fn().Verified:
tsc --noEmit(both player tsconfig projects) +oxfmt --checkpass.🤖 Generated with Claude Code