fix(engine): suppress font-loading 404 noise in render console output#195
Merged
Conversation
3 tasks
Collaborator
Author
This was referenced Apr 2, 2026
jrusso1020
reviewed
Apr 2, 2026
5a3e099 to
f4a4d76
Compare
vanceingalls
previously requested changes
Apr 2, 2026
vanceingalls
left a comment
Collaborator
There was a problem hiding this comment.
Review feedback — requesting changes
Critical: Error filter is too broad
The current filter in packages/engine/src/services/frameCapture.ts:
if (type === "error" && text.startsWith("Failed to load resource")) return;This suppresses ALL "Failed to load resource" errors, not just font 404s. A missing image, video, or script during rendering would be silently swallowed. This could mask real bugs.
Narrow to font-specific patterns:
if (type === "error" && text.startsWith("Failed to load resource") &&
/fonts\.googleapis|fonts\.gstatic|\.woff2?/i.test(text)) return;Or at minimum match only 404 status + known font CDN domains.
040c458 to
f81757e
Compare
2a564cf to
096f09b
Compare
Collaborator
Author
|
Fixed. Narrowed the filter to match only font-specific 404s: const isFontLoadError =
type === "error" &&
text.startsWith("Failed to load resource") &&
/fonts\.googleapis|fonts\.gstatic|\.woff2?(\b|$)/i.test(text);This catches font CDN domains (fonts.googleapis.com, fonts.gstatic.com) and .woff/.woff2 file extensions. Missing images, scripts, and videos will still surface as |
vanceingalls
approved these changes
Apr 2, 2026
806f008 to
0694b9e
Compare
f81757e to
36582e6
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ssing Address review feedback: instead of silently dropping "Failed to load resource" errors (which could hide real asset failures), keep them in browserConsoleBuffer for diagnostics but don't print to stdout. Real asset 404s are still caught by the file server's own logging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
36582e6 to
e76e312
Compare
0694b9e to
7f4e433
Compare
Address review: filter was too broad and could suppress real asset failures. Now only suppresses 404s matching fonts.googleapis, fonts.gstatic, or .woff2 file extensions. Missing images, scripts, and videos will still surface as [Browser:ERROR] in render output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e76e312 to
dc47aa7
Compare
miguel-heygen
added a commit
that referenced
this pull request
Apr 3, 2026
…#195) * fix(engine): suppress font-loading 404 noise in render console output Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(engine): downgrade resource 404s to buffer-only instead of suppressing Address review feedback: instead of silently dropping "Failed to load resource" errors (which could hide real asset failures), keep them in browserConsoleBuffer for diagnostics but don't print to stdout. Real asset 404s are still caught by the file server's own logging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(engine): narrow 404 filter to font CDN domains and woff2 files only Address review: filter was too broad and could suppress real asset failures. Now only suppresses 404s matching fonts.googleapis, fonts.gstatic, or .woff2 file extensions. Missing images, scripts, and videos will still surface as [Browser:ERROR] in render output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Filters "Failed to load resource" console errors from render output. These 404s come from font
@importURLs that the deterministic font compiler replaces with embedded base64 — the original URLs 404 harmlessly but spam every render with 4+ error lines.The
validatecommand already has this exact filter (validate.ts:104). This applies the same pattern to the render engine.Part 3 of 5 in a stacked PR series fixing E2E test findings.
Test plan
gsap is not defined) still appear