Skip to content

style: apply oxfmt baseline formatting across all source files#21

Closed
vanceingalls wants to merge 1 commit into
vance/va-851-2-lint-fixesfrom
vance/va-851-3-baseline-formatting
Closed

style: apply oxfmt baseline formatting across all source files#21
vanceingalls wants to merge 1 commit into
vance/va-851-2-lint-fixesfrom
vance/va-851-3-baseline-formatting

Conversation

@vanceingalls

Copy link
Copy Markdown
Collaborator

Summary

  • Run oxfmt . across the entire codebase to establish formatted baseline
  • 299 files changed — mechanical formatting only, no logic changes
  • Double quotes, semicolons, 2-space indent, trailing commas, 100 print width

Part 3/4 of VA-851

Test plan

  • pnpm format:check — all 426 files pass
  • pnpm -r typecheck — all packages pass
  • pnpm build — all packages build
  • All 348 tests pass

🤖 Generated with Claude Code

@linear

linear Bot commented Mar 23, 2026

Copy link
Copy Markdown
VA-851 [Pre-Migration] Configure ESLint, Prettier, and conventional commits

Context

The codebase currently has no linting or formatting enforcement. Code is clean by convention, but OSS contributors need automated guardrails. Team feedback: "I love when an open source repo has this."

What to do

  1. ESLint — add configuration at monorepo root with TypeScript rules. Extend from @typescript-eslint/recommended.
  2. Prettier — add .prettierrc at root. Configure for the existing code style (double quotes, no semicolons or with — match what's already there).
  3. Conventional commits — add commitlint config enforcing conventional commit format (feat:, fix:, refactor:, etc.). This enables automated changelog generation later.
  4. Run formatter across all source files to establish baseline (single "format" commit in internal repo before port).
  5. Add lint/format scripts to root package.json: pnpm lint, pnpm format, pnpm format:check
  6. Verify all existing code passes lint + format checks with zero errors

Why before port

We want the OSS repo's first commit to already have these configs in place and all code conforming. No "fix linting" commits in public history.

@vanceingalls vanceingalls deleted the vance/va-851-3-baseline-formatting branch March 23, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant