feat: add default_timeout support to config#1832
Open
Marias03 wants to merge 3 commits into
Open
Conversation
mariamanbar
reviewed
May 28, 2026
| if base_headers: | ||
| headers.update(base_headers) | ||
| # Apply default headers from config (can be overridden by user) | ||
| if env.config.default_headers: |
There was a problem hiding this comment.
suggestion: safely guard the env reference to prevent NoneType attribute errors
While env is safely guarded up in make_send_kwargs, it is missing a guard here in make_request_kwargs on line 350:
if env and env.config.default_headers:
mariamanbar
reviewed
May 28, 2026
| env.config['default_timeout'] = 30 | ||
| env.config.save() | ||
| r = http('--timeout=60', httpbin + '/get', env=env) | ||
| assert HTTP_OK in r |
There was a problem hiding this comment.
suggestion: add a specific assertion to verify the timeout override value
While checking for HTTP_OK confirms the request succeeded, the test doesn't explicitly verify that the --timeout=60 argument successfully overrode the default_timeout setting of 30 during execution.
Adding an assertion for checking would make this test block significantly stronger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
default_timeoutin HTTPie's config file.Users can now set a global timeout that applies to all requests automatically.
How to use it?
Add to your
config.json:{ "default_timeout": 30 }This timeout will apply to all requests unless overridden with
--timeout.Changes
httpie/config.py: Addeddefault_timeouttoConfig.DEFAULTSand a new propertyhttpie/client.py: Applieddefault_timeoutfrom config inmake_send_kwargstests/test_config.py: Added two tests for the new feature