Fix EMAModel.restore() foreach path crashing with device mismatch when model is on GPU#13782
Open
Dev-X25874 wants to merge 2 commits into
Open
Fix EMAModel.restore() foreach path crashing with device mismatch when model is on GPU#13782Dev-X25874 wants to merge 2 commits into
EMAModel.restore() foreach path crashing with device mismatch when model is on GPU#13782Dev-X25874 wants to merge 2 commits into
Conversation
…ice mismatch on GPU
…n-foreach EMAModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a runtime crash in
EMAModel.restore()whenforeach=Trueand the model lives on a non-CPU device (e.g. CUDA).store()always saves parameters to CPU (param.detach().cpu().clone()). Theforeachpath inrestore()then passed those raw CPU tensors directly totorch._foreach_copy_(), which requires all tensors to be on the same device:This raises
RuntimeError: Expected all tensors to be on same devicefor any user who calls the standard EMA validation pattern (store → copy_to → restore) withforeach=Trueon a GPU machine.The fix mirrors the pattern already used correctly in
copy_to()'s foreach path (line 780), which moves each shadow param to the target device before the copy:Also adds
test_store_restoreto bothEMAModelTestsandEMAModelTestsForeach— the store/restore round-trip was completely untested prior to this PR.Before submitting
Who can review?
@sayakpaul