Skip to content

Rename 'CLIPFeatureExtractor' class to 'CLIPImageProcessor'#2732

Merged
patrickvonplaten merged 1 commit into
huggingface:mainfrom
ainoya:rename-CLIPFeatureExtractor-to-CLIPImageProcessor
Mar 23, 2023
Merged

Rename 'CLIPFeatureExtractor' class to 'CLIPImageProcessor'#2732
patrickvonplaten merged 1 commit into
huggingface:mainfrom
ainoya:rename-CLIPFeatureExtractor-to-CLIPImageProcessor

Conversation

@ainoya

@ainoya ainoya commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

The 'CLIPFeatureExtractor' class name has been renamed to 'CLIPImageProcessor' in order to comply with future deprecation. This commit includes the necessary changes to the affected files.

ref: https://github.com/huggingface/transformers/blob/2355e463955a5392c1acf1964d89747e8b146a6f/src/transformers/models/clip/feature_extraction_clip.py#L29

The 'CLIPFeatureExtractor' class name has been renamed to 'CLIPImageProcessor' in order to comply with future deprecation. This commit includes the necessary changes to the affected files.
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Mar 18, 2023

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten patrickvonplaten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great nice PR! @williamberman @sayakpaul could you check here?

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this one!

Well done 🔥

@patrickvonplaten

patrickvonplaten commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

Just verified that CLIPImageProcessor exists since transformers==4.25.0 - we should probably then also update the min requirement => it's already the case:

"transformers>=4.25.1",

Alright merging then 🔥 nicely done @ainoya

@patrickvonplaten patrickvonplaten merged commit 14e3a28 into huggingface:main Mar 23, 2023
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
…ace#2732)

The 'CLIPFeatureExtractor' class name has been renamed to 'CLIPImageProcessor' in order to comply with future deprecation. This commit includes the necessary changes to the affected files.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
…ace#2732)

The 'CLIPFeatureExtractor' class name has been renamed to 'CLIPImageProcessor' in order to comply with future deprecation. This commit includes the necessary changes to the affected files.
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ace#2732)

The 'CLIPFeatureExtractor' class name has been renamed to 'CLIPImageProcessor' in order to comply with future deprecation. This commit includes the necessary changes to the affected files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants