Skip to content

[Init] Make sure shape mismatches are caught early#2847

Merged
patrickvonplaten merged 1 commit into
mainfrom
better_error_message
Mar 28, 2023
Merged

[Init] Make sure shape mismatches are caught early#2847
patrickvonplaten merged 1 commit into
mainfrom
better_error_message

Conversation

@patrickvonplaten

@patrickvonplaten patrickvonplaten commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Currently when loading mismatches checkpoints (config and checkpoint doesn't match), we don't get an immediate error, but we should since the forward pass won't work.

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Mar 27, 2023

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🍩

@pcuenca pcuenca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The referenced issue was very helpful, maybe we could consider to include that use-case somewhere in the documentation :)

Comment thread src/diffusers/models/modeling_utils.py
@patrickvonplaten patrickvonplaten merged commit 42d9501 into main Mar 28, 2023
@patrickvonplaten patrickvonplaten deleted the better_error_message branch March 28, 2023 08:08
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants