Make sure Diffusers works even if Hub is down#3447
Merged
Conversation
patrickvonplaten
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
pcuenca
reviewed
May 16, 2023
pcuenca
left a comment
pcuenca
left a comment
Member
There was a problem hiding this comment.
The design looks good! It's easy to understand what's going on. It took a moment to remember that hf_hub_download does not really download if the file is cached, so this is good.
patrickvonplaten
changed the title
Collaborator
|
Nice! |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Make sure Diffusers works even if Hub is down * Make sure hub down is well tested
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Make sure Diffusers works even if Hub is down * Make sure hub down is well tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to add tests and check that PR indeed makes sure
diffusersstill works when Hub is down. Should resolve: #3372Thanks a lot for the design idea @Wauplin
@sayakpaul @pcuenca wdyt about the design?