Dataflow: Record content types by aschackmull · Pull Request #2 · hvitved/codeql

aschackmull · 2020-06-17T13:43:08Z

When removing content types from the language-specific interface we need to track both container types and content types in store steps.

hvitved

Just a few tedious comments.

hvitved · 2020-06-17T14:50:28Z

+) {
+  readStep(n1, c, n2) and
+  container = getErasedRepr(n1.getTypeBound()) and
+  content = getErasedRepr(n2.getTypeBound())


Might as well use getErasedNodeTypeBound() in both lines.

hvitved · 2020-06-17T14:51:12Z

+
+  Content getContent() { this = TReadStepTypesSome(_, result, _) }
+
+  DataFlowType getType() { this = TReadStepTypesSome(_, _, result) }


Rename to getContentType() (?)

Java: Fix qltests for github#3653

…efinition Python: Add test for tricky module member for type-tracking

Java: Review fixes.

Rewrite extractor in rust

This is in order to avoid name clash with the often so-named IPA type for data- flow nodes. The name clash is not problematic because they are both in scope, but because (cached) IPA types with overlapping names are known to sometimes result in re-evaluation of cached stages, when one of the IPA types gets an internal `#2` suffix in one query run, and the other IPA type gets the suffix in another run.

Fix tests.

DIL before ``` /* AST::AstNode */ AST#87953007::Cached::TAstNode result) = fastTC(AST#a6718388::AstNode::getAChild#0#dispred#ff/2) . Synthesis#d9ff06b1::isInDesugaredContext#1#f(/* AST::AstNode */ unique AST#87953007::Cached::TAstNode n) :- exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ | arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, n) ); exists(/* AST::AstNode */ AST#87953007::Cached::TAstNode call_result#2 | exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ | arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, call_result#2) ), #AST#a6718388::AstNode::getAChild#0#dispredPlus#ff(call_result#2, n) ) . ``` DIL after ``` incremental Synthesis#d9ff06b1::isInDesugaredContext#1#f(/* AST::AstNode */ unique AST#87953007::Cached::TAstNode n) :- exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ | arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, n) ); exists(/* AST::AstNode */ AST#87953007::Cached::TAstNode any#expr##2 | rec Synthesis#d9ff06b1::isInDesugaredContext#1#f(any#expr##2), exists(cached dontcare string _ | AST#a6718388::AstNode::getAChild#1#dispred(any#expr##2, _, n) ) ) | [base_case] exists(int arg1, /* AST::AstNode */ dontcare AST#87953007::Cached::TAstNode _ | arg1 = -1, AST#87953007::Cached::getSynthChild#2(_, arg1, n) ) | [delta_order] exists(/* AST::AstNode */ AST#87953007::Cached::TAstNode any#expr##2 | delta previous rec Synthesis#d9ff06b1::isInDesugaredContext#1#f(any#expr##2), project#AST#a6718388::AstNode::getAChild#1#dispred(any#expr##2, n) ), not(previous rec Synthesis#d9ff06b1::isInDesugaredContext#1#f(n)) . ``

…for-unused-parameters-2 Go: make `ParameterNode`s for unused parameters #2 (make a disjoint class for unused ones)

C++: Fix zstd and clean up test

Refactor CfgScopes and Ast predicate names

Split sources by taint type

Test: Remove location parsing

Go: Add database source models for the github.com/couchbase/gocb package (#2)

Go: Add `database` source models for the `squirrel` package (#2)

JS: Add isMiddlewareSetup() hook to Routing model

Implement first stage cryptography modelling and queries

Java: Fix SpringRequestMappingMethod URL Extraction #2

…ction-sink Go: Add BigQuery as a sink for SQLi queries #2

Set CWE-134 from 9.3 to 7.3 CVSS score for memory safe languages (#2)

Signature model refactor experimental

…8e3d-0895-49ec-9025-a9864c8e5367 Fix generate-code-scanning-query-list.py to handle empty code-quality-extended suites

…ainer-steps Python: Remove imprecise container steps #2

aschackmull added 2 commits June 17, 2020 15:40

Dataflow: Record content type for stores.

10b64fc

Dataflow: Sync.

d28b5ac

aschackmull mentioned this pull request Jun 17, 2020

Data flow: Track precise types during field flow github/codeql#3456

Merged

hvitved requested changes Jun 17, 2020

View reviewed changes

aschackmull added 3 commits June 17, 2020 17:03

Dataflow: minor review fixes.

543ab71

Dataflow: autoformat

cedfaf6

Dataflow: Fix qltest.

74eab3c

hvitved merged commit ad56f17 into hvitved:dataflow/precise-field-types Jun 17, 2020

aschackmull deleted the dataflow/content-type-tracking branch June 18, 2020 14:23

hvitved pushed a commit that referenced this pull request Jul 28, 2020

Merge pull request #2 from aschackmull/java/spring-3653-2

443c13d

Java: Fix qltests for github#3653

hvitved pushed a commit that referenced this pull request Oct 27, 2020

Merge pull request #2 from RasmusWL/python-tricky-import-ssa-filter-d…

802a725

…efinition Python: Add test for tricky module member for type-tracking

hvitved pushed a commit that referenced this pull request Nov 27, 2020

Merge pull request #2 from aschackmull/java/ssrf-review

9c30b82

Java: Review fixes.

hvitved pushed a commit that referenced this pull request Jun 28, 2021

Manually improve tests #2

044ecc5

hvitved pushed a commit that referenced this pull request Nov 2, 2021

Merge pull request #2 from github/aibaars/extractor-rust

467e32a

Rewrite extractor in rust

hvitved pushed a commit that referenced this pull request Mar 8, 2022

Merge pull request #2 from geoffw0/fix_tests

5c80139

Fix tests.

hvitved pushed a commit that referenced this pull request Aug 3, 2023

Merge pull request github#13672 from owen-mc/go/make-parameter-nodes-…

5f76caf

…for-unused-parameters-2 Go: make `ParameterNode`s for unused parameters #2 (make a disjoint class for unused ones)

hvitved pushed a commit that referenced this pull request Sep 11, 2024

Merge pull request #2 from jketema/amammad-cpp-bombs

05bdce1

C++: Fix zstd and clean up test

hvitved pushed a commit that referenced this pull request Dec 20, 2024

Merge pull request #2 from GitHubSecurityLab/refactor_cfgscope

e9c1114

Refactor CfgScopes and Ast predicate names

hvitved pushed a commit that referenced this pull request Dec 20, 2024

Merge pull request #2 from github/separate_sources

186f9d0

Split sources by taint type

hvitved pushed a commit that referenced this pull request Feb 4, 2025

Merge pull request #2 from hvitved/js/source-on-same-line

7bf69d9

Test: Remove location parsing

hvitved pushed a commit that referenced this pull request Mar 26, 2025

Merge pull request github#19088 from owen-mc/review/egregius313/18913

6d61820

Go: Add database source models for the github.com/couchbase/gocb package (#2)

hvitved pushed a commit that referenced this pull request Mar 28, 2025

Merge pull request github#19090 from owen-mc/review/egregius313/18902

dc242da

Go: Add `database` source models for the `squirrel` package (#2)

hvitved pushed a commit that referenced this pull request Apr 30, 2025

Merge pull request #2 from asgerf/js/fastify-addhook

63402ea

JS: Add isMiddlewareSetup() hook to Routing model

hvitved pushed a commit that referenced this pull request May 13, 2025

Merge pull request #2 from nicolaswill/knewbury01/JCA-sample

83617e0

Implement first stage cryptography modelling and queries

hvitved pushed a commit that referenced this pull request May 23, 2025

Merge pull request github#19556 from owen-mc/java/pr/19512

663c83d

Java: Fix SpringRequestMappingMethod URL Extraction #2

hvitved pushed a commit that referenced this pull request Jun 4, 2025

Merge pull request github#19561 from owen-mc/go/mad/bigquery-sql-inje…

e7e4286

…ction-sink Go: Add BigQuery as a sink for SQLi queries #2

hvitved pushed a commit that referenced this pull request Jun 12, 2025

Merge pull request github#19738 from owen-mc/pr/felickz/19530

538a5af

Set CWE-134 from 9.3 to 7.3 CVSS score for memory safe languages (#2)

hvitved pushed a commit that referenced this pull request Oct 4, 2025

Merge pull request #2 from bdrodes/signature_model_refactor_experimental

73b3398

Signature model refactor experimental

hvitved pushed a commit that referenced this pull request Nov 7, 2025

Merge pull request #2 from felickz/copilot/fix-1760475-601388369-59cd…

20e23f8

…8e3d-0895-49ec-9025-a9864c8e5367 Fix generate-code-scanning-query-list.py to handle empty code-quality-extended suites

hvitved pushed a commit that referenced this pull request Dec 1, 2025

Improve formatting of tags #2

220fd08

hvitved pushed a commit that referenced this pull request Dec 1, 2025

Use set literals #2

992bd68

hvitved pushed a commit that referenced this pull request Jun 7, 2026

Merge pull request github#21888 from owen-mc/py/remove-imprecise-cont…

1f91f91

…ainer-steps Python: Remove imprecise container steps #2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dataflow: Record content types#2

Dataflow: Record content types#2
hvitved merged 5 commits into
hvitved:dataflow/precise-field-typesfrom
aschackmull:dataflow/content-type-tracking

aschackmull commented Jun 17, 2020

Uh oh!

hvitved left a comment

Uh oh!

hvitved Jun 17, 2020

Uh oh!

hvitved Jun 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		Content getContent() { this = TReadStepTypesSome(_, result, _) }

		DataFlowType getType() { this = TReadStepTypesSome(_, _, result) }

Conversation

aschackmull commented Jun 17, 2020

Uh oh!

hvitved left a comment

Choose a reason for hiding this comment

Uh oh!

hvitved Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

hvitved Jun 17, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants