test: cover slash conversion policies#53
Merged
Conversation
Merging this PR will degrade performance by 11.4%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | string |
226.7 ns | 255.8 ns | -11.4% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing agent/slash-policy-matrix (e4372a2) with main (36ea1df)
Footnotes
-
38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
815fc30 to
e4372a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str,String,Path, borrowedPathBuf, and consumingPathBufreceiversCowownership on Unix and Windows, including UNC spelling, mixed separators, repeated and trailing separators, and multibyte UTF-8This PR changes tests only. It does not change production code, dependencies, benchmarks, or benchmark inputs.
Validation
SUGAR_PATH_EXPECT_CACHED_CURRENT_DIR=0 cargo +1.97.0 test --locked -p sugar_pathSUGAR_PATH_EXPECT_CACHED_CURRENT_DIR=1 cargo +1.97.0 test --locked --workspace --all-featurescargo +1.97.0 fmt --all -- --checkcargo +1.97.0 clippy --locked --workspace --all-targets --all-features -- -D warningsx86_64-pc-windows-msvcthrough a dependency-only harness, avoiding the repository dev-only mimalloc build that requires a local Windows SDKFinal coverage audit
try_into_slashcases asserted pointer and capacity identity even though storage reuse is an optimization rather than part of the returned value contract.At the rebased head
e4372a2, all eight repository Actions jobs pass. Native Windows confirms that the invalid-wide recovery test and valid receiver-policy matrix execute under both default and all features; Linux and macOS likewise execute their Unix policy cases.External CodSpeed alone reports
as_path/rolldown_corpus/string226.7→255.8 ns (-11.4%) while explicitly warning that the runtime environments differ. This is the exact non-attributable result already observed on merged test-only PR #52; this PR's diff contains only tests and changes no production code, dependency, benchmark, or benchmark input.