test: preserve invalid cwd encoding#65
Merged
Merged
Conversation
828915d to
73b3054
Compare
73b3054 to
6771854
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relative_withWhy
Existing invalid-encoding tests covered target and base paths, but not cwd components consumed while resolving relative inputs. A controlled mutation that silently dropped every non-UTF-8 cwd component passed the complete default and
cached_current_dirsuites. It changed the correct raw result../invalid-\x80/targetinto../anchor/target.The new test reaches that shared resolution stack through the public API and catches the mutation with an exact byte assertion.
Validation
cached_current_dirconfigurationscargo fmt --all --checkandgit diff --check