docs(examples): add an example of handler based routing - #3821
Closed
randomairborne wants to merge 1 commit into
Closed
docs(examples): add an example of handler based routing#3821randomairborne wants to merge 1 commit into
randomairborne wants to merge 1 commit into
Conversation
Adds an example showing more complex routing functionality than that in web_api. Builds off web_api with a more complex, reusable router framework.
Author
|
I am curious- I noticed that the other examples tend to contain fairly few comments. Is this intentional? |
Member
I won't say it's intentional. More likely, the author thought the parts are easy to understand so a comment is unnecessary. If the comment can explain what's happening, it's good to have. But if it's more of a guide, then we can put it in the website instead. |
Member
|
I appreciate the interesting example! However, I'm trying to now limit how many examples are in the repository, since they increase compile/test time and maintenance. It would certainly be an interesting blog post, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example showing more complex routing functionality than that in web_api. Builds off web_api with a more complex, reusable router framework.
This is a pretty complex example, it has more lines of code than any other example except single_thread. It may need to be pared down- do not hesitate to let me know if there's anything that's overcomplicated or needs to be changed.