Additional options for rolling ball background subtraction#143
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #143 +/- ##
====================================
+ Coverage 30% 33% +3%
====================================
Files 25 25
Lines 1763 1806 +43
====================================
+ Hits 527 591 +64
+ Misses 1236 1215 -21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lguerard
force-pushed
the
rollingball_options
branch
from
d33a0a6 to
cd48fac
Compare
ehrenfeu
changed the title
ehrenfeu
added
enhancement
Member
|
Please add test 🧪 coverage 🕵🏼 - I've started a basic one in 373a05c but since this is just about generating strings and calling macro commands, we should be able to reach full 🚀 coverage. |
ehrenfeu
requested changes
Apr 17, 2026
added 2 commits
April 20, 2026 12:20
Update parameter names for clarity
ehrenfeu
requested changes
Jun 24, 2026
Comment on lines
+184
to
+198
| rolling_ball_radius : int | ||
| Radius of the rolling ball filter to use | ||
| light_background : bool, optional | ||
| If set to True, will treat the background as light, by default False | ||
| sliding : bool, optional | ||
| If set to True, will do a sliding window approach, by default False | ||
| disable_smoothing : bool, optional | ||
| If set to True, will disable the smoothing, by default False | ||
| do_3d : bool, optional | ||
| If set to True, will do a 3D filtering, by default False | ||
|
|
||
| Returns | ||
| ------- | ||
| str | ||
| The options string for the "Subtract Background..." macro command |
ehrenfeu
requested changes
Jun 24, 2026
Comment on lines
+184
to
+198
| rolling_ball_radius : int | ||
| Radius of the rolling ball filter to use | ||
| light_background : bool, optional | ||
| If set to True, will treat the background as light, by default False | ||
| sliding : bool, optional | ||
| If set to True, will do a sliding window approach, by default False | ||
| disable_smoothing : bool, optional | ||
| If set to True, will disable the smoothing, by default False | ||
| do_3d : bool, optional | ||
| If set to True, will do a 3D filtering, by default False | ||
|
|
||
| Returns | ||
| ------- | ||
| str | ||
| The options string for the "Subtract Background..." macro command |
Member
|
🕵🏼🕵🏼🕵🏼 (More changes requested...) |
ehrenfeu
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Enhance rolling ball background subtraction with additional opt…
…ions