fix(system-bars): use separate current styles - #8409
Merged
Merged
Conversation
jcesarmobile
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
March 27, 2026 17:17
OS-pedrogustavobilro
approved these changes
Mar 31, 2026
3 tasks
fabiomartino
added a commit
to fabiomartino/capacitor
that referenced
this pull request
Aug 23, 2026
Resolve the SystemBars.java three-way conflict keeping the automatic edge-to-edge and universal keyboard architecture from this branch (ionic-team#8366) while adopting upstream's structural changes: - insetsHandling as a validated string field with Logger.warn fallback (upstream ionic-team#8481), replacing the boolean gate across listener registration, initial CSS variables, and onDOMReady - separate status bar and gesture bar style tracking (upstream ionic-team#8409) - per-bar show/hide with else-if semantics (upstream ionic-team#8480) - viewport JS text block TODO note for the future 'full' option Fold in compatible ideas from open PR ionic-team#8454: - navBarVisible tracking in setHidden so hidden navigation bars do not contribute phantom bottom insets - navigation_bar_height resource fallback for legacy (API < 30) OEM builds reporting zero-height nav insets, suppressed for lint (InternalInsetResource, DiscouragedApi) since no supported API exposes a static navigation bar height - IME visibility fallback below Android O via ime inset bottom > 0 - store requested styles so DEFAULT keeps following system theme changes when reapplied on configuration change or resume PR ionic-team#8528's SDK gate for IME padding needs no code here: this branch never applies window IME padding (keyboard is handled via CSS variables and the inset builder), so double keyboard spacing on API <= 34 cannot occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bars can be styled separately, track the current style per bar
closes #8396