docs(intro): update packages & CDN to redirect to other guides - #4286
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
commented
Oct 17, 2025
brandyscarney
commented
Oct 17, 2025
brandyscarney
commented
Oct 17, 2025
brandyscarney
commented
Nov 12, 2025
| #### 1. Install the Packages | ||
|
|
||
| ```bash | ||
| npm install @ionic/vue @ionic/vue-router vue-router |
Member
Author
There was a problem hiding this comment.
The @ionic/vue-router and vue-router installs are here instead of under "Set up Routing" like the React guide because @ionic/vue errors without vue-router being installed and it seemed weird to only install it without also including @ionic/vue-router.
brandyscarney
commented
Nov 12, 2025
brandyscarney
commented
Nov 12, 2025
| Update `src/app/app.html` to the following: | ||
|
|
||
| ```html title="src/app/app.html" | ||
| <ion-button>Button</ion-button> <ion-datetime></ion-datetime> |
Member
Author
There was a problem hiding this comment.
These being on the same line was done by the docs linter.
Contributor
There was a problem hiding this comment.
It would really be great if we can figure out how to keep them separate.
brandyscarney
commented
Nov 12, 2025
brandyscarney
commented
Nov 12, 2025
brandyscarney
commented
Nov 12, 2025
brandyscarney
commented
Nov 13, 2025
thetaPC
reviewed
Nov 13, 2025
thetaPC
requested changes
Nov 13, 2025
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
My requested changes also apply to v7 when applicable.
| Update `src/app/app.html` to the following: | ||
|
|
||
| ```html title="src/app/app.html" | ||
| <ion-button>Button</ion-button> <ion-datetime></ion-datetime> |
Contributor
There was a problem hiding this comment.
It would really be great if we can figure out how to keep them separate.
thetaPC
reviewed
Nov 14, 2025
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
LGTM, with minor suggestions but not blockers.
thetaPC
approved these changes
Nov 14, 2025
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
Oops, didn't select approve. Here ya go!
ShaneK
approved these changes
Nov 14, 2025
brandyscarney
enabled auto-merge (squash)
November 18, 2025 17:09
brandyscarney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #446 in combination with #4322
What is the current behavior?
The Packages & CDN guide has some information on how to get started with Angular, React and Vue but these sections are incomplete. For example, we cover how to add React to an existing app here but it is missing a lot of steps that are documented in the guide here. It doesn't make sense to have the same information in two places.
What is the new behavior?
This PR updates the Packages & CDN guide to redirect out to the
Quickstart&Add to Existingguides for the packages, but keeps the CDN content in the Packages & CDN guide. React was the only framework that already had anAdd to Existingguide, so this also addsAdd to Existingguides for Angular & Vue and moves the content from the Packages & CDN guide to those.Ionic Packages & CDN Guide Changes
Below is a before & after of the CDN page (right-click and open the image in a new tab to see the images larger):
Add to Existing Guide Changes
React
Angular
Vue
Important
The React URL has changed. I set up redirects for this and have left the deleted files in to update the JP docs before removing them in this PR: #4329