bug: Ionic React routerDirection "none" causes BackButton to go to defaultHref

[babycourageous]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

• v4.x
• v5.x
• v6.x

Current Behavior

I think based on my understanding of the routerDirection prop, I think this may be a bug-

When routing via Item, Button, etc with routerLink and routerDirection if routerDirection is set to "none" the back button on the routed to page goes to the defaultHref instead of the page you came from.

ionic-direction-none.mov

Expected Behavior

BackButton should use history to determine where to go back to, even with "none" as routerDirection

Steps to Reproduce

Example REPO

From Tab 1 -
Button 1 routes as default with a forward direction and then you go back to Tab 1.
Button 2 routed with direction "none" and will then take you back to Tab 2 (the defaultHref for the Back Button)

Code Reproduction URL

https://github.com/babycourageous/ionic-router-direction-none-bug

Ionic Info

Ionic:

Ionic CLI : 6.17.1 (/Users/renedellefont/.fnm/node-versions/v14.17.6/installation/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 5.8.4

Capacitor:

Capacitor CLI : 3.2.5
@capacitor/android : not installed
@capacitor/core : 3.2.5
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 1.5.0

System:

NodeJS : v14.17.6 (/Users/renedellefont/.fnm/node-versions/v14.17.6/installation/bin/node)
npm : 6.14.15
OS : macOS Big Sur

Additional Information

If this is the intended behavior I can PR to the docs to perhaps clarify that section. Thanks!

[liamdebeasi]

Thanks for the issue. I can reproduce this behavior in both Ionic React and Ionic Vue. The issue seems to be that we only consider a route as getting "pushed" if routerAction is push and routerDirection is forward: https://github.com/ionic-team/ionic-framework/blob/main/packages/vue-router/src/router.ts#L224

To me this seems incorrect since routerDirection only impacts the direction in which the animation plays (forward, backward, not at all, etc) and should not impact the router history. Because of this behavior, we do not set the pushedByRoute value property on the route information. This results in the following check failing when clicking the back button: https://github.com/ionic-team/ionic-framework/blob/main/packages/vue-router/src/router.ts#L109

I will look into a fix for this. Thanks!

[babycourageous]

Thanks a lot @liamdebeasi !